Feature/add skipped tag for pending tests#21
Open
samcarver4 wants to merge 3 commits intolambdaisland:mainfrom
Open
Feature/add skipped tag for pending tests#21samcarver4 wants to merge 3 commits intolambdaisland:mainfrom
samcarver4 wants to merge 3 commits intolambdaisland:mainfrom
Conversation
Add "skipped" to JUnit XSD spec. Since JUnit 4, "skipped" is allowed: 1. In the testsuite as an attribute which counts the number of skipped tests. 2. In the testcase element as an element which indicates that a test was skipped.
Add count of pending tests to count of "skipped" tests (as these tests don't actually run). Report this in the testsuite attribute. Add "skipped" element to the "pending" testcase in the XML report. Update tests to reflect the new schema with the "skipped" keyword
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a fix for Issue #20 (Reporting test cases marked with "pending" Kaocha tag as "skipped" in JUnit XML output).
This makes three changes to the junit_xml.clj file:
:skippedkey to thestatsfunction that features the total of:pendingtests fromkaocha.result/totals->clojure-test-summary. This allows a total of "skipped" tests to be reported in the XML file with the test results.skipped->xmlfunction, following the pattern demonstrated in failure->xml and error->xml. This will allow individual tests to include a "skipped" tag.skipped->xmlfunction to thetestcase->xmllogic.This also updates the tests and the JUnit XSD spec accordingly.