Skip to content

Conversation

@julianstirling
Copy link
Contributor

Use Jinja templating for the fallback rather than direct string replacing

Before:

image

After:

image

@barecheck
Copy link

barecheck bot commented Jan 9, 2026

Barecheck - Code coverage report

Total: 96.26%

Your code coverage diff: 0.03% ▴

Uncovered files and lines
FileLines
src/labthings_fastapi/server/cli.py97, 157, 178

Copy link
Collaborator

@rwb27 rwb27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've read through this briefly - it clearly works and it looks like you've tested the relevant things and made provision for any of the new stuff to fail without breaking the fallback server. I'm very happy to see it merged on that basis. It looks immeasurably better than the old page!

@rwb27 rwb27 merged commit f6bdd99 into main Jan 9, 2026
44 of 54 checks passed
@rwb27 rwb27 deleted the pretty-fallback branch January 9, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants