Allow build to link to an already installed liblsl version #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Find via "LIBLSL_LIB_DIR" environment variable Can automatically find on macos if installed with homebrew
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build will first find a liblsl via the
LIBLSL_LIB_DIRenvironment variable.Additionally, the build can automatically find the library on MacOS if installed with homebrew.
Fallback to building the library from source, as is done currently.
I wrote this pr as for some reason liblsl cannot be compiled on my system via CMake, and this was easier than fixing the liblsl build.