Add ComicInfo.xml to generated CBZ #1
Conversation
|
hi do you know if its possible to download all the episodes of a manga? with this project? |
|
@uzi98f It depends on the manga, it is just a way to download images from shueisha's mangaplus service, so it only downloads chapter you are able to see from the android/ios app. But if you pay the subscription and configure the system to use your account (see here: hurlenko#36) you should be pretty much able to download all of them. |
l0westbob
left a comment
l0westbob
left a comment
There was a problem hiding this comment.
Thank you for your recommendations, but please clean up your changes.
| from io import BytesIO | ||
| from pathlib import Path | ||
| from typing import Union | ||
|
|
mloader/exporters/cbz_exporter.py
Outdated
| import logging | ||
| log = logging.getLogger(__name__) | ||
|
|
mloader/exporters/cbz_exporter.py
Outdated
|
|
||
| log.info(f"close") | ||
|
|
|
|
||
| # Generate and write ComicInfo.xml to the archive | ||
| comicinfo_xml = self._generate_comicinfo_xml() | ||
| xml_path = Path(self.chapter_name, "ComicInfo.xml") | ||
| self.archive.writestr(xml_path.as_posix(), comicinfo_xml) | ||
|
|
||
| # Finalize archive |
There was a problem hiding this comment.
What happens with the ZIP file in a case of an error while creating the xml file?
| """ | ||
| Generate a basic ComicInfo.xml metadata file. | ||
| See: https://github.com/anansi-project/comicinfo | ||
| Returns: | ||
| str: The ComicInfo.xml content as a string. | ||
| """ |
There was a problem hiding this comment.
Okay, how about:
"""
Generate a basic ComicInfo.xml metadata file.
See: https://github.com/anansi-project/comicinfo
Returns:
str: The ComicInfo.xml content as a string.
Notes:
- Values are XML-escaped to ensure the output is well-formed even if
metadata contains special characters (e.g., '&', '<', '>').
- The language code is derived from the base class via _iso_language().
"""
| return f"""<?xml version="1.0" encoding="utf-8"?> | ||
| <ComicInfo> | ||
| <Series>{self.title_name}</Series> | ||
| <Number>{self.chapter_number}</Number> | ||
| <Title>{self.chapter_title}</Title> | ||
| <Writer>{self.author}</Writer> | ||
| <LanguageISO>{self._iso_language()}</LanguageISO> | ||
| <Manga>YesAndRightToLeft</Manga> | ||
| <Publisher>Shueisha</Publisher> | ||
| <Genre>Manga</Genre> | ||
| </ComicInfo> | ||
| """ |
There was a problem hiding this comment.
Thisd should be in a constant, not raw in the return
| import logging | ||
| log = logging.getLogger(__name__) | ||
|
|
|
|
||
| # log.info(f"chapter: {chapter}") | ||
| # log.info(f"title: {title}") | ||
|
|
| self.language = title.language | ||
| self.author = title.author | ||
| self.chapter_title = chapter.sub_title | ||
| self.chapter_number = chapter.name |
There was a problem hiding this comment.
Fine, but please add a new line and a comment like this above:
Add meta data
| def _iso_language(self) -> str: | ||
|
|
||
| l = Language(self.language) | ||
| if l == Language.ENGLISH: | ||
| return 'en' | ||
| elif l == Language.SPANISH: | ||
| return 'es' | ||
| elif l == Language.FRENCH: | ||
| return 'fr' | ||
| elif l == Language.INDONESIAN: | ||
| return 'id' | ||
| elif l == Language.PORTUGUESE: | ||
| return 'pt' | ||
| elif l == Language.RUSSIAN: | ||
| return 'ru' | ||
| elif l == Language.THAI: | ||
| return 'th' | ||
| elif l == Language.GERMAN: | ||
| return 'de' | ||
| elif l == Language.VIETNAMESE: | ||
| return 'vi' | ||
| else: | ||
| return 'en' | ||
|
|
There was a problem hiding this comment.
function itself is okay but these are no go's:
- No docstring
- single character variable names -> be expressive
- why the if, elif wall of doom instead of a map?
3 participants
Hello,
I would like to add the ComicInfo.xml file inside the CBZ archive to provide metadata for comic readers.
See here: https://github.com/anansi-project/comicinfo for specification.