Skip to content

Conversation

@tdashton
Copy link
Contributor

The migration from kununu-scripts to here seems to have not migrated the indifference to yoda rules, so I migrate it here with the description of the PR below:


We prefer to leave the behavior up to the projects, i.e. if yoda style leave it if not leave it too.

The documentation of php cs is officially

  [yoda_style] Rule must be enabled (true), disabled (false) or configured (non-empty, assoc array). Other values are not allowed. To disable the rule, use "FALSE" instead of "NULL".

The configuration here is a more explicit version of false.

@tdashton tdashton requested a review from a team as a code owner September 16, 2025 09:59
@tdashton tdashton changed the title - no strict yoda style will return, he will No strict yoda style will return, he will Sep 16, 2025
@github-actions
Copy link

Qodana for PHP

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@danielsantos-kununu
Copy link
Collaborator

@tdashton please check this Teams thread and align with @hugo-goncalves-kununu, seems you're working on same thing?

@hugo-goncalves-kununu
Copy link
Collaborator

No problem with this PR, I am working on a new major release

@tdashton
Copy link
Contributor Author

@hugo-goncalves-kununu @danielsantos-kununu ah thanks for the note!

Then feel free to approve if this won't conflict with the major version update, or we can close otherwise!

@tdashton tdashton merged commit 2dc3259 into main Sep 16, 2025
4 checks passed
@tdashton tdashton deleted the yoda-returns branch September 16, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants