Skip to content
This repository was archived by the owner on Sep 12, 2023. It is now read-only.

Add MaxConcurrentReconciles to JobControllerConfiguration#205

Open
Syulin7 wants to merge 4 commits intokubeflow:masterfrom
Syulin7:add_maxreconciles
Open

Add MaxConcurrentReconciles to JobControllerConfiguration#205
Syulin7 wants to merge 4 commits intokubeflow:masterfrom
Syulin7:add_maxreconciles

Conversation

@Syulin7
Copy link
Contributor

@Syulin7 Syulin7 commented Jan 15, 2023

add MaxConcurrentReconciles to JobControllerConfiguration

fixes: kubeflow/trainer#1707 (comment)

@google-oss-prow
Copy link

google-oss-prow bot commented Jan 15, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign terrytangyuan for approval by writing /assign @terrytangyuan in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Syulin7
Copy link
Contributor Author

Syulin7 commented Jan 15, 2023

@johnugeorge PTAL, I will do this in training operator once this is merged.

@google-oss-prow google-oss-prow bot added size/M and removed size/XS labels Jan 16, 2023
@Syulin7
Copy link
Contributor Author

Syulin7 commented Jan 16, 2023

@johnugeorge I update license, please approve running workflows, thanks.

@johnugeorge
Copy link
Member

johnugeorge commented Jan 17, 2023

We can wait till kubeflow/trainer#1714 is completed. This will make it easy to make common changes

@Syulin7
Copy link
Contributor Author

Syulin7 commented Jan 18, 2023

ok, I agree.

@Syulin7
add MaxConcurrentReconciles to JobControllerConfiguration
84f05c3 
Signed-off-by: Syulin7 <735122171@qq.com>
@Syulin7
update License
4776ad4 
Signed-off-by: Syulin7 <735122171@qq.com>
@Syulin7
fix go mod
ff1fab8 
Signed-off-by: Syulin7 <735122171@qq.com>
@Syulin7
fix go mod
43d6a89 
Signed-off-by: Syulin7 <735122171@qq.com>
@google-oss-prow google-oss-prow bot added size/S and removed size/M labels Jan 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Jeffwan Jeffwan Awaiting requested review from Jeffwan

@terrytangyuan terrytangyuan Awaiting requested review from terrytangyuan

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Syulin7 @johnugeorge