This repository was archived by the owner on Aug 7, 2024. It is now read-only.
Homework check #46
Open
Homework check #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krottv
suggested changes
Jun 20, 2022
| container: ViewGroup?, | ||
| savedInstanceState: Bundle? | ||
| ): View { | ||
| fragment = SongFragmentBinder(this) |
| import com.github.krottv.tmstemp.presentation.SongDownloadViewModel | ||
|
|
||
| class SongUploadWorker( | ||
| private val songDownloadViewModel: SongDownloadViewModel, |
Owner
There was a problem hiding this comment.
songDownloadViewModel -> smth else
| return data.size | ||
| } | ||
|
|
||
| private fun setRoundRect(imageView: ImageView, dp: Int) { |
|
|
||
| override fun onStartCommand(intent: Intent?, flags: Int, startId: Int): Int { | ||
| downloadingJob?.cancel() | ||
| downloadingJob = CoroutineScope(SupervisorJob() + Dispatchers.Main).launch { |
Owner
There was a problem hiding this comment.
scope в отдельную переменную, отменить.
| ): View { | ||
| fragment = HostFragmentBinding.inflate(inflater) | ||
|
|
||
| storagePermissionChecker = StoragePermissionCheckerImpl(requireActivity()) |
|
|
||
| private lateinit var fragment: HostFragmentBinding | ||
| private val sharedPreferences: SharedPreferences by inject() | ||
| private val albumsFragment = AlbumsFragment() |
Owner
There was a problem hiding this comment.
Нельзя тут создавать и хранить фрагменты. findFragmentByTag()
| isClickable = false | ||
| } | ||
|
|
||
| setSecondary(primary) |
| } | ||
|
|
||
| companion object { | ||
| lateinit var appContext: Context |
Owner
There was a problem hiding this comment.
Антипаттерн - нельзя контекст хранить
| import com.github.krottv.tmstemp.domain.SongModel | ||
|
|
||
| interface TracksMyMusicDataSource { | ||
| suspend fun getTracks(): List<SongModel> |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.