This repository was archived by the owner on Nov 24, 2020. It is now read-only.
Fix for the JSON decode error.#20
Open
Clearmist wants to merge 1 commit intokriansa:masterfrom
Clearmist:master
Open
Fix for the JSON decode error.#20Clearmist wants to merge 1 commit intokriansa:masterfrom Clearmist:master
Clearmist wants to merge 1 commit intokriansa:masterfrom
Clearmist:master
Conversation
…tes I made PhantomJS.php base64 encode the string. converter.js now base64 decodes the string before JSON decoding it. ConverterAbstract.php now encodes the URI with three forward slashes to allow PhantomJS to load temporary files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be able to pass a JSON string through the shell and retain its quotes I made PhantomJS.php base64 encode the string. converter.js now base64 decodes the string before JSON decoding it. ConverterAbstract.php now encodes the URI with three forward slashes to allow PhantomJS to load temporary files.