feat: add customized URL path extension property to navigate action #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedepini
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
resourceURLPathExtensionproperty fornavigateactions in widgets that support it.Currently, a
navigateaction can redirect either to a string-based path or to a resource (i.e. another widget) via theresourceRefIdkey. This new feature applies to the latter case and allows defining a custom URL path extension, which is a string that is appended to the current URL location during navigation.Consider the following scenario: a Button redirects to a resource using
resourceRefId.This is what happens after clicking the button when no
resourceURLPathExtensionis specified:After the redirect, the target resource is displayed on a page with a different URL but the same title (in the breadcrumb). In the UI, the only difference between the two pages is their content.
When a
resourceURLPathExtensionis set (in this examplebutton-dashboard), the behaviour changes as follows:After the redirect, the target resource is displayed on a page with a different title (in the breadcrumb), clearly emphasizing the distinction between the two pages.
Additionally, this PR fixes a Sidebar bug that prevented the selected key from being displayed correctly when using complex URLs.