Diff nil and empty for slice and map #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This would be a nice improvement. If you're using pretty.Diff as part of a test failure message, it can be kind of mysterious why the diff is empty even though reflect.DeepEqual returns false. @kr any reason not to merge? The change LGTM. |
|
+1 I'd also like to see this merged! |
mkabilov
pushed a commit
to zalando/postgres-operator
that referenced
this pull request
May 12, 2017
- Use the branch of pretty with this feature fixed: kr/pretty#42 - Add the Limit to the resources declaration to avoid dummy differences between statefulsets (where both Resource structures are empty, but in one case the fields are not mentioned, while in another they are assigned to empty values).
|
For anyone else wanting this, your best bet is probably to just switch to @motomux' fork at https://github.com/motomux/pretty. |
YuriSalesquw
pushed a commit
to YuriSalesquw/postgres-operator
that referenced
this pull request
Dec 26, 2022
- Use the branch of pretty with this feature fixed: kr/pretty#42 - Add the Limit to the resources declaration to avoid dummy differences between statefulsets (where both Resource structures are empty, but in one case the fields are not mentioned, while in another they are assigned to empty values).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#41