Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/magic_enum.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@
require 'magic_enum/class_methods'

ActiveRecord::Base.extend(MagicEnum::ClassMethods)
ActiveResource::Base.extend(MagicEnum::ClassMethods) if defined?(::ActiveResource)
14 changes: 7 additions & 7 deletions lib/magic_enum/class_methods.rb
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@ module ClassMethods
# StatusesInverted = Statuses.invert
#
# def status
# return StatusesInverted[self[:status].to_i] || StatusesInverted[1]
# return StatusesInverted[self.attributes[:status].to_i] || StatusesInverted[1]
# end
#
# def status=(value)
# raise ArgumentError, "Invalid value \"#{value}\" for :status attribute of the #{self.class} model" if Statuses[value].nil?
# self[:status] = Statuses[value]
# self.attributes[:status] = Statuses[value]
# end
#
# def unknown?
Expand Down Expand Up @@ -98,25 +98,25 @@ def define_enum(name, opts = {})
else
a <=> b
end
end.first unless opts[:default]
end.first unless opts.has_key?(:default)

const_set(enum_inverted, const_get(enum).invert)

define_method name do
self.class.const_get(enum_inverted)[self[name]] || self.class.const_get(enum_inverted)[opts[:default]]
self.class.const_get(enum_inverted)[self.attributes[name]] || self.class.const_get(enum_inverted)[opts[:default]]
end

define_method "#{name}_name" do
send(name).to_s
end

define_method "#{name}=" do |value|
value = value.to_sym if value.is_a?(String)
value = value.to_sym if value.is_a?(String) && value.length > 0
raise ArgumentError, "Invalid value \"#{value}\" for :#{name} attribute of the #{self.class} model" if opts[:raise_on_invalid] and self.class.const_get(enum)[value].nil?
if value.is_a?(Integer)
self[name] = value
self.attributes[name] = value
else
self[name] = self.class.const_get(enum)[value] || opts[:default]
self.attributes[name] = self.class.const_get(enum)[value] || opts[:default]
end
end

Expand Down
33 changes: 32 additions & 1 deletion spec/magic_enum_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@
require 'active_record'

require File.dirname(__FILE__) + '/../init'
require File.dirname(__FILE__) + '/../lib/magic_enum'

module MagicEnumHelper
class TestModelBase
include MagicEnum
extend MagicEnum::ClassMethods
Statuses = { :unknown => 0, :draft => 1, :published => 2 }

def [](attr_name)
Expand All @@ -15,6 +16,12 @@ def [](attr_name)
def []=(attr_name, value)
@status = value
end
attr_accessor :attributes

def initialize(*args)
super
@attributes = {}
end
end
end

Expand Down Expand Up @@ -52,6 +59,11 @@ class TestModel1 < MagicEnumHelper::TestModelBase
@model.status.should == :unknown
end

specify 'use a default value if the string is empty' do
@model.status = ''
@model[:status].should == 0
end

specify 'should store enum value if key is given as integer equivalent' do
@model.status = 1
@model[:status].should == 1
Expand Down Expand Up @@ -125,6 +137,25 @@ class TestModel2 < MagicEnumHelper::TestModelBase
end
end

context 'Model with magic enum and default value of nil' do
include MagicEnumHelper

class TestModelNil < MagicEnumHelper::TestModelBase
define_enum :status, :default => nil
end

setup do
@model = TestModelNil.new
end

specify 'should use default value when current state is invalid' do
@model.status = :draft
@model.status.should == :draft
@model.status = nil
@model.status.should == nil
end
end

describe 'Model with magic enum and raise_on_invalid option specified' do
include MagicEnumHelper

Expand Down