KIP-4: "create2" Host Function for pWASM#4
Open
sorpaas wants to merge 5 commits intokovan-testnet:masterfrom
Open
KIP-4: "create2" Host Function for pWASM#4sorpaas wants to merge 5 commits intokovan-testnet:masterfrom
sorpaas wants to merge 5 commits intokovan-testnet:masterfrom
Conversation
|
There might be no regular create ever used on chain, so we might as well replace the behaviour of regular create? |
Author
|
@NikVolf I'm worried it might break consensus. At any moment that assumption may be broken because deploying a contract using |
|
can this also be updated to avoid mentioning id-s (like #6)? (i cant do it myself, since it's pr from fork) also CREATE2 should be create2, since wasm imports are not capitalized |
Author
|
Done! |
|
Please, don't forget to update the docs https://paritytech.github.io/pwasm-ethereum/pwasm_ethereum/ (enable kip4 feature) when the KIP will be merged and fork will be enabled. |
|
KIP 4 will be activated on Kovan block 9_200_000, please finalize and merge spec. |
See887777
approved these changes
Mar 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rel openethereum/parity-ethereum#9139
(Rendered)
I found no other KIPs in this repo for reference, so please let me know if anything's not right.