-
Notifications
You must be signed in to change notification settings - Fork 41
Adding correct usage across the rulesets for from filepaths #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Adding correct usage across the rulesets for from filepaths #256
Conversation
jmle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Good catch
|
Going to close and reopen to refresh CI workflows. |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. |
84e6114 to
803d9b2
Compare
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (22)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@jmle @aufi @eemcmullan Can y'all give another round of reviews after the rebase? |
803d9b2 to
dcf877c
Compare
* Some rules had the from as a capability arg, which would be ignored * Some rules had a from and were not using the filepaths to filter Signed-off-by: Shawn Hurley <shawn@hurley.page>
dcf877c to
de7b0b3
Compare
fixes #257