SKOverlay + SKStoreProductViewController #31
Merged
JakubMrozek merged 25 commits intodevelopfrom Feb 18, 2026
Merged
Conversation
phiviet01
force-pushed
the
duc/skoverlay
branch
from
b72c29c to
e6ccfb5
Compare
phiviet01
force-pushed
the
duc/skoverlay
branch
2 times, most recently
from
d156b09 to
4c63ef2
Compare
phiviet01
force-pushed
the
duc/skoverlay
branch
from
4c63ef2 to
4b63b5c
Compare
JakubMrozek
changed the title
…meComponent support
…prove parameter passing
…oved readability and maintainability
…ecessary named parameters for improved clarity
phiviet01
force-pushed
the
duc/skoverlay
branch
from
ab3c9a4 to
030dba1
Compare
JakubMrozek
changed the title
JakubMrozek
changed the title
Member
Author
|
A small note: I think the implementation of SKStoreProductViewController is good and everything works well. But I would prefer to adjust the timing of when we send the update-skstoreproduct-iframe event. In this file, it looks like we send the event immediately when the user closes the window, but there is an animation involved. It would be better to send the event after the animation finishes, so we can be sure that the SKStoreProductViewController is actually shown or fully closed. In the future, there may be a chain of actions that depends on this timing. That said, we probably don’t need to change it right now @Duc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.