Open
Conversation
patrickdappollonio
suggested changes
Sep 22, 2024
patrickdappollonio
left a comment
patrickdappollonio
left a comment
There was a problem hiding this comment.
This is awesome 💚
I'm worried of approving it myself though since I'm not sure if we're using actual kustomize (the CLI) to process this or if we're doing this programatically.
If we are doing it programatically, we cannot merge this until we know on the receiving end that the parameters to the SDK have been changed to account for the path location drift (iirc, there's a clone on the consuming side).
Might wanna check with @jokestax!
Will keep this as "request changes" since I would hate to see it merged then break something. Happy to shift it to "approved" if on the other end we use the CLI.
jokestax
reviewed
Sep 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I didn't like we had identical kustomize directories with the
job.spec.template.containers.argsbeing the only thing different between them. This PR adds a base which both directories (deployment types) can reference. I have kept changes as minimal as possible so that we don't have to make change inkubefirst-apiorkubefirstrepository.Related Issue(s)
Fixes # None
How to test
Output of this command before should match before changes in this PR