forked from jonathan0211/konduto-ruby
-
Notifications
You must be signed in to change notification settings - Fork 6
feat: Add delivery and seller fields to shopping cart item #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MrChampz
wants to merge
26
commits into
konduto:master
Choose a base branch
from
MrChampz:feat/delivery_to_passenger
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adiciona os arquivos de exemplos para os campos da API Konduto
Adiciona alguns campos faltantes mas classes: * konduto_address * konduto_customer * konduto_item * konduto_payment
This commit introduces new attributes to the shopping cart item: - `delivery_type` - `delivery_sla_in_minutes` - `seller_id` The `image` attribute has been removed from the shopping cart item. The `README.md` file has been updated to reflect these changes and to adjust the requirement level of several other fields, changing them from optional to recommended. Tests and factories have been updated to align with these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new attributes to the shopping cart item:
delivery_typedelivery_sla_in_minutesseller_idThe
imageattribute has been removed from the shopping cart item.The
README.mdfile has been updated to reflect these changes and to adjust the requirement level of several other fields, changing them from optional to recommended.Tests and factories have been updated to align with these changes.