-
Notifications
You must be signed in to change notification settings - Fork 65
P/R to make it working with SonarQube 7.2-7.3 #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- switched to apache http client instead of slack client
|
Hi @sleroy, If your PR isn't eventually merged, and you decide to maintain your plugin, I've got a PR of my own that I want merged here, maybe you'd want it as well. TLDR: Enable per-project web hooks (sth I needed myself). See: #27 Cheers. UPDATE: OK, I just saw you've got mine included already! Thanks! |
|
@el95149 : indeed your P/R was great, I have integrated it. However I may need some help to test all the new features contained in my release. |
|
@sleroy Shout when you need it and I'll give you a hand. |
|
I have released a version there : https://github.com/sleroy/sonar-slack-notifier-plugin/releases |
Enable project specific web hook
|
Hi @sleroy Thank you for your work. Since this repo seems to be dead, would you like to continue the work on your repo? If so, then could you open the Issue tab so people can open new issues and such? Thanks. |
OK, I am opening the issue tab on my repo. |
|
Thank you. |
Use with java 8 and enforce notification on specific branch
I have released on my fork a working version of this plugin including several pull requests of @brunopadz @zhuopeng @gmilosavljevic @dbsanfte @bitzl and @el95149.
I also have upgraded the plugin to make it working with 7.2 and 7.3 APIs.
I have replaced the webhook call to use OkHttp directly to offer proxy features.
Can you merge it ? If you don't have time or motivation, please tell it to me, I may maintain the plugin;
Best,
Sylvain