Skip to content

Conversation

@sleroy
Copy link

@sleroy sleroy commented Feb 23, 2019

I have released on my fork a working version of this plugin including several pull requests of @brunopadz @zhuopeng @gmilosavljevic @dbsanfte @bitzl and @el95149.

I also have upgraded the plugin to make it working with 7.2 and 7.3 APIs.

I have replaced the webhook call to use OkHttp directly to offer proxy features.

Can you merge it ? If you don't have time or motivation, please tell it to me, I may maintain the plugin;

Best,

Sylvain

@el95149
Copy link

el95149 commented Feb 23, 2019

Hi @sleroy, If your PR isn't eventually merged, and you decide to maintain your plugin, I've got a PR of my own that I want merged here, maybe you'd want it as well. TLDR: Enable per-project web hooks (sth I needed myself).

See: #27

Cheers.

UPDATE: OK, I just saw you've got mine included already! Thanks!

@sleroy
Copy link
Author

sleroy commented Feb 23, 2019

@el95149 : indeed your P/R was great, I have integrated it. However I may need some help to test all the new features contained in my release.

@el95149
Copy link

el95149 commented Feb 23, 2019

@sleroy Shout when you need it and I'll give you a hand.
Cheers.

@sleroy
Copy link
Author

sleroy commented Feb 23, 2019

I have released a version there : https://github.com/sleroy/sonar-slack-notifier-plugin/releases

@Indigo744
Copy link

Hi @sleroy

Thank you for your work. Since this repo seems to be dead, would you like to continue the work on your repo? If so, then could you open the Issue tab so people can open new issues and such?

Thanks.

@sleroy
Copy link
Author

sleroy commented Dec 12, 2019

Hi @sleroy

Thank you for your work. Since this repo seems to be dead, would you like to continue the work on your repo? If so, then could you open the Issue tab so people can open new issues and such?

Thanks.

OK, I am opening the issue tab on my repo.

@Indigo744
Copy link

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants