Match current state of kpi subsequences refactor #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anticipation of matching changes to kobotoolbox/kpi
…following the new shape of transcripts and translations
jnm
added a commit
to kobotoolbox/kpi
that referenced
this pull request
Dec 17, 2025
* update formpack requirement (see kobotoolbox/formpack#337) * exclude qualitative analysis note (`qualNote`) questions from export columns * restore `name` from earlier refactor work in `get_output_fields()` * correct order of fields in `analysis_form_json` * restore `pack.extend_survey()` during exports, missing after evil merge
9 tasks
rgraber
previously approved these changes
Dec 17, 2025
Contributor
rgraber
left a comment
rgraber
left a comment
There was a problem hiding this comment.
Looks good to my limited knowledge of formpack
| except KeyError: | ||
| return '' | ||
|
|
||
| # sure would be nice if this were a dict with uuids as keys instead of |
rgraber
added a commit
to kobotoolbox/kpi
that referenced
this pull request
Dec 18, 2025
### 💭 Notes * use `value` instead of `val` in qualitative analysis responses to match rest of refactor * update formpack requirement (see kobotoolbox/formpack#337) * match pre-refactor behavior by excluding qualitative analysis note (`qualNote`) questions from export columns * restore `name` from earlier refactor work in `get_output_fields()` * correct order of fields in `analysis_form_json` * restore `pack.extend_survey()` during exports, missing after evil merge 👿 ### 👀 Preview steps 1. Make sure your environment has been rebuilt or whatever's necessary to pick up the new formpack requirement 2. Make a project with an audio question 3. Collect a submission 4. Add every kind of transcript, translation, and qualitative analysis question (and response) to the audio response in that submission * FYI I wrote notes in the description of DEV-1301 (internal [link](https://linear.app/kobotoolbox/issue/DEV-1301/update-formpack-to-accept-new-shape-of-data)) about how to do this with `curl` 6. Run an XLSX export of the project 7. Make sure all the export includes the transcript, translation, and all qualitative analysis responses 8. Make sure the export columns are in the proper order 9. Make sure nothing appears that shouldn't --------- Co-authored-by: rgraber <becca.graber@kobotoolbox.org>
rgraber
added a commit
to kobotoolbox/kpi
that referenced
this pull request
Dec 24, 2025
* use `value` instead of `val` in qualitative analysis responses to match rest of refactor * update formpack requirement (see kobotoolbox/formpack#337) * match pre-refactor behavior by excluding qualitative analysis note (`qualNote`) questions from export columns * restore `name` from earlier refactor work in `get_output_fields()` * correct order of fields in `analysis_form_json` * restore `pack.extend_survey()` during exports, missing after evil merge 👿 1. Make sure your environment has been rebuilt or whatever's necessary to pick up the new formpack requirement 2. Make a project with an audio question 3. Collect a submission 4. Add every kind of transcript, translation, and qualitative analysis question (and response) to the audio response in that submission * FYI I wrote notes in the description of DEV-1301 (internal [link](https://linear.app/kobotoolbox/issue/DEV-1301/update-formpack-to-accept-new-shape-of-data)) about how to do this with `curl` 6. Run an XLSX export of the project 7. Make sure all the export includes the transcript, translation, and all qualitative analysis responses 8. Make sure the export columns are in the proper order 9. Make sure nothing appears that shouldn't --------- Co-authored-by: rgraber <becca.graber@kobotoolbox.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See kobotoolbox/kpi#6561