Skip to content

fix: format 8 digits chilean rut #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dagalloso wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: format 8 digits chilean rut #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/cl/rut.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,18 @@ import {
} from '../exceptions';

describe('cl/rut', () => {
it('format:800280610', () => {
it('format:125319092', () => {
const result = format('125319092');

expect(result).toEqual('12.531.909-2');
});

it('format:77272305', () => {
const result = format('77272305');

expect(result).toEqual('7.727.230-5');
});

it('validate:76086428-5', () => {
const result = validate('76086428-5');

Expand Down
4 changes: 1 addition & 3 deletions src/cl/rut.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,7 @@ const impl: Validator = {
format(input: string): string {
const [value] = clean(input);

const [a, b, c, d] = strings.splitAt(value, 2, 5, 8);

return `${a}.${b}.${c}-${d}`;
return `${value.slice(0, -7)}.${value.slice(-7, -4)}.${value.slice(-4, -1)}-${value.slice(-1)}`;
Copy link

@gemini-code-assist gemini-code-assist bot Oct 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While the use of multiple slice() calls is correct, it can be a bit difficult to read and verify the indices at a glance. A regular expression can make this formatting logic more declarative and easier to understand. It also has the benefit of not producing a malformed string if the input doesn't match the expected RUT structure (e.g., for inputs with an incorrect length).

Suggested change
return `${value.slice(0, -7)}.${value.slice(-7, -4)}.${value.slice(-4, -1)}-${value.slice(-1)}`;
return value.replace(/^(\d{1,2})(\d{3})(\d{3})(.)$/, '$1.$2.$3-$4');

},

/**
Expand Down