fix(live-news): destroy player before offline/error message (fixes #347)#410
Merged
fix(live-news): destroy player before offline/error message (fixes #347)#410
Conversation
…347) showOfflineMessage() and showEmbedError() replaced innerHTML without cleaning up this.player, so initializePlayer() bailed early on the next channel switch — leaving a black screen. destroyPlayer() is idempotent so the onError path won't double-destroy. Co-authored-by: N Cho-chin <Niboshi-Wasabi@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Owner
Author
|
Deployed in #410 (comment) |
20 tasks
Owner
Author
|
thank you @Niboshi-Wasabi |
Merged
koala73
added a commit
that referenced
this pull request
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
showOfflineMessage()andshowEmbedError()replacedthis.content.innerHTMLwithout callingdestroyPlayer(), leavingthis.playersetinitializePlayer()bailed early → black screenthis.destroyPlayer()at the top of both methods — it's idempotent so theonErrorpath won't double-destroyCloses #347
Co-authored-by: N Cho-chin (Niboshi-Wasabi) — original diagnosis in #388
Test plan