Skip to content

Make the jsx parser pass child elements as parameters #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deefco wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make the jsx parser pass child elements as parameters #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion packages/utils.jsx/src/jsx.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@

import { attr } from '@tko/binding.core/src/attr'
import {
isObservable, unwrap
} from '@tko/observable'
Expand Down Expand Up @@ -45,10 +46,21 @@ export function getOriginalJsxForNode (node) {
* @param {...string|object} c children of the element
*/
export function createElement (elementName, attributes, ...children) {
const internalAttributes = attributes || {};
if(internalAttributes.hasOwnProperty('children')) {
console.error(
"%s: `children` cannot be used as an attribute. It gets automatically bound to the child elements of this component. " +
"If you want to access the same value within the child component, you should pass it as a different attribute.",
elementName
);
}

internalAttributes.children = [...children] || []

return elementName === Fragment ? children
: {
elementName: elementName,
attributes: attributes || {},
attributes: internalAttributes,
children: [...children]
}
}
Expand Down