Rewrite to loop. Add env parse #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmolan
reviewed
Oct 23, 2025
|
|
||
| sum | ||
| } | ||
|
|
Owner
There was a problem hiding this comment.
all tests go to the tests/ folder, see https://github.com/kmolan/const_poly/blob/main/tests/function_approximations_tests.rs
Owner
|
@nrot I am not seeing the point of this Pr. We already have close to 1e-12 accuracy with current methods, what advantage will it give us to parametrize and rolling the loop? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the calculation of sin, cos by analogy with sinh through the series.
Added the ability to specify the row length via env.