Skip to content

Default apiGroup field to "" in TypedLocalObjectReference #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tamalsaha merged 2 commits into from
Sep 30, 2025
Merged

Default apiGroup field to "" in TypedLocalObjectReference #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24a54de
omitempty the apiGroup field
ArnobKumarSaha Sep 29, 2025
cb88e9f
defaulting
ArnobKumarSaha Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apis/appcatalog/v1alpha1/appbinding_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,8 @@ type TypedLocalObjectReference struct {
// If APIGroup is not specified, the specified Kind must be in the core API group.
// For any other third-party types, APIGroup is required.
// +optional
APIGroup *string `json:"apiGroup"`
// +kubebuilder:default=""
APIGroup string `json:"apiGroup"`
// Kind is the type of resource being referenced
// +kubebuilder:default="Secret"
Kind string `json:"kind"`
Expand Down
1 change: 1 addition & 0 deletions apis/appcatalog/v1alpha1/openapi_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 2 additions & 7 deletions apis/appcatalog/v1alpha1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions crds/appcatalog.appscode.com_appbindings.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ spec:
namespace that will hold the credentials associated with the AppBinding.
properties:
apiGroup:
default: ""
description: |-
APIGroup is the group for the resource being referenced.
If APIGroup is not specified, the specified Kind must be in the core API group.
Expand Down Expand Up @@ -285,6 +286,7 @@ spec:
the client certificate and private key associated with the AppBinding.
properties:
apiGroup:
default: ""
description: |-
APIGroup is the group for the resource being referenced.
If APIGroup is not specified, the specified Kind must be in the core API group.
Expand Down
3 changes: 2 additions & 1 deletion openapi/swagger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2604,7 +2604,8 @@
"properties": {
"apiGroup": {
"description": "APIGroup is the group for the resource being referenced. If APIGroup is not specified, the specified Kind must be in the core API group. For any other third-party types, APIGroup is required.",
"type": "string"
"type": "string",
"default": ""
},
"kind": {
"description": "Kind is the type of resource being referenced",
Expand Down