Skip to content

Replace panic with error log in IsOpenClusterSpoke to avoid unnecessary crashes #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RokibulHasan7 wants to merge 2 commits into from
Closed

Replace panic with error log in IsOpenClusterSpoke to avoid unnecessary crashes #630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d4735a
Replace panic with error log in IsOpenClusterSpoke to avoid unnecessa…
RokibulHasan7 Oct 24, 2025
539e46a
Update
tamalsaha Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/v1/cluster_enum.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion api/v1/object_enum.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cluster/ocm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ func IsOpenClusterSpoke(kc client.Reader) bool {
err := kc.List(context.TODO(), &list)
if err != nil {
if !meta.IsNoMatchError(err) && !apierrors.IsNotFound(err) {
panic(err) // panic if 403 (missing rbac)
klog.Errorln(err)
}
}
return len(list.Items) > 0
Expand Down
Loading