Fix: Custom range may not fetch events consistently with UI #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Custom range is selected in the UI,
FromDateTimeandToDateTimeinherit the time information of the previously selected time (such as 4/18/2025 23:29:43.111). This can cause some events (such as at 4/18/2025 23:29:12) slipped out.To workaround, we could display second in the date time picker, but it's still confusing as we don't show millisecond information anyway. Rather, I chose to round down the date time objects to minute-base to match them to UI when custom range is selected.
Fixes #83