Skip to content

Add a delete feature#55

Open
c3dr0x wants to merge 2 commits intodevelopfrom
feature-delete-comment
Open

Add a delete feature#55
c3dr0x wants to merge 2 commits intodevelopfrom
feature-delete-comment

Conversation

@c3dr0x
Copy link
Contributor

@c3dr0x c3dr0x commented Nov 11, 2017

Fix #54

The point is for one user to be able to delete one of its comments.

there is new options :

  • canDelete: to allow user to delete
  • texts.delete: translation string for delete action

There a new service server side to implement:

  • DELETE /api/comments/{uuid}

@rodolpheV
Copy link

Found the problem with the delay on deleteing comments:
In component\list\index.js:
Change line 9 from
const TRANSITION_TIMEOUT = 5000;
to
const TRANSITION_TIMEOUT = 300;
It will remove the 5 second delay before delete.
Then in component\list\style.scss:
Add:

.comment-leave {
    -webkit-animation-duration: 0.3s;
    animation-duration: 0.3s;
    -webkit-animation-name: fadeOutRight;
    animation-name: fadeOutRight;
}

It will add a pretty animation like the one on add comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments