Increase priority of constant rule in grammar (#108) #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klauer
approved these changes
Jul 14, 2025
Owner
klauer
left a comment
klauer
left a comment
There was a problem hiding this comment.
The test suite is passing, but CI is failing due to Codecov still (even after a token update and re-running the jobs). I'll have to figure out what's going on there separately.
In the meantime, these changes look good - merging with a rule bypass. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108. I also added a test that verifies some basic expectations about the parsing of boolean literals. It does so by checking that some key token (e.g. constant, TRUE_VALUE) can be found somewhere in the parse tree. The test is parametrized so that it can be reused for further checks of a similar kind.