This repository was archived by the owner on Jan 11, 2019. It is now read-only.
eslint-plugin-react@6.10.0 breaks build 🚨 #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
eslint-plugin-react just published its new version 6.10.0.
This version is covered by your current version range and after updating it in your project the build went from success to failure.
As eslint-plugin-react is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.
I recommend you give this issue a high priority. I’m sure you can resolve this 💪
Of course this could just be a false positive, caused by a flaky test suite, or third parties that are currently broken or unavailable, but that would be another problem I’d recommend working on.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
GitHub Release
Added
forbid-foreign-prop-typesrule (#696 @iancmyers)void-dom-elements-no-childrenrule (#709 @lencioni)forbid-elementsrule (#887 @kentor)noSortAlphabeticallyoption tojsx-sort-props(#541 #786 @markus101)whenoption tojsx-max-props-per-line(#878 @kentor)nextPropstoprop-types(#814)Fixed
require-default-propscrash (#1029)require-default-propsrule when using Flow type from assignment (#1043 @wyze @CarlRosell)style-prop-objectto not warn with explicitnullorundefined(#812 @ljharb)no-unused-prop-typesprops detection in stateless components (#885 @BarryThePenguin)display-namefalse positive withdocument.createElement(#996 @jomasti)Changed
The new version differs by 178 commits .
83d4c4bUpdate CHANGELOG and bump versionee144d6Merge pull request #890 from kentor/forbid-elements3e2421eMerge pull request #946 from BarryThePenguin/no-unused-prop-types-in-jsx3b25a3bMerge pull request #882 from kentor/jsx-max-props-per-line-updates54abb8bMerge pull request #1055 from iancmyers/icm-forbid-foreign-prop-type0b25b66Add forbid-foreign-prop-types rulec586273Merge pull request #1062 from dguo/patch-28e207b8Fix no-array-index-key typod884a98Add new rule: forbid-elementsc97dd0fMerge pull request #1051 from yannickcr/void-dom-elements-no-childrena84d5f5jsx-max-props-per-line: Use json format in docs9af8d25fix commentsd5c3e91detect used props in jsxb52f3b8jsx-max-props-per-line: Add additional test casesb485e28jsx-max-props-per-line: AddwhenoptionThere are 178 commits in total. See the full diff.
Screencast
Try it today. Free for private repositories during beta.