This repository was archived by the owner on Jan 11, 2019. It is now read-only.
jsdom@9.9.1 breaks build 🚨 #46
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
jsdom just published its new version 9.9.1.
This version is covered by your current version range and after updating it in your project the build went from success to failure.
As jsdom is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.
I recommend you give this issue a high priority. I’m sure you can resolve this 💪
Of course this could just be a false positive, caused by a flaky test suite, or third parties that are currently broken or unavailable, but that would be another problem I’d recommend working on.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
The new version differs by 46 commits .
5f949cfVersion 9.9.17c2861dDon't use .includes yet05e0c53Version 9.9.0fedc336Add CDATA sections30f7906Add document.embeds, plugins, and scripts5261738Implement document.title correctly per-specae19887Implement document.body correctly per-spec656f606Add more selector testsbb12085Fix CORS POST JSON XHRs with Authorization8bb591dFix EventListener once handling45f4458Add Node's wholeText property3c50533Only log "not implemented" errors if form submission isn't canceled60555c0Allow insertAdjacentHTML without a parent element sometimes139b9d7Upgrade whatwg-url dependency to 4.1.04c40a11Fix a README typoThere are 46 commits in total. See the full diff.
This pull request was created by greenkeeper.io.
Tired of seeing this sponsor message? ⚡
greenkeeper upgrade