Translation for posting an updated resource#22
Open
massmediagroup-87 wants to merge 4 commits intokirschbaum-development:1.xfrom
Open
Translation for posting an updated resource#22massmediagroup-87 wants to merge 4 commits intokirschbaum-development:1.xfrom
massmediagroup-87 wants to merge 4 commits intokirschbaum-development:1.xfrom
Conversation
Member
|
@massmediagroup-87 Thank you for this. I will review as soon as I get a chance. |
Contributor
|
Probably you need to create a file with a translation into en to en. |
Member
|
Agreed @4n70w4. It would be good to add a translation config to this package. @massmediagroup-87 please update your code as it is out-of-date. And include a publishable config for language files. Please try to duplicate the code style in the package. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I've tried to translate component but there is some hardcoded text which can be translated.
so, I added translations into js
These changes make it possible to translate a message that pops up after a resource has been updated.
It would be nice to have it merged, they may be helpful.