Skip to content

Comments

Improve freeflow immersion: Jump To seeks playback and keep scroll position#885

Merged
killergerbah merged 10 commits intokillergerbah:mainfrom
L-M-Sherlock:jump-to-seek
Feb 16, 2026
Merged

Improve freeflow immersion: Jump To seeks playback and keep scroll position#885
killergerbah merged 10 commits intokillergerbah:mainfrom
L-M-Sherlock:jump-to-seek

Conversation

@L-M-Sherlock
Copy link
Contributor

@L-M-Sherlock L-M-Sherlock commented Feb 15, 2026

My current workflow of Free-Flow Immersion:

  1. I hide the subtitle during watching.
  2. When I don't understand the current dialogue, I use "Mine current subtitle" to add the current line to the mining history. I learn this method from Add timestamps bookmark function when doing freeflow listening #374 (comment)
  3. When I finish the entire episode, I open the mining history and mine the unknown cards.

The problems of the current workflow:

  1. The "jump to" doesn't affect the video. To use it, I have to show the subtitle list and locate the video via clicking the subtitle located by "jump to".
  2. After I mine the unknown word via yomitan, the web-socket-server help me add the picture and sentence audio. But this action refresh the mining history with a new log, which let me have to locate the next line I want to jump to again. When I have 30+ logs in the mining history, it's annoying because I have to spend 50% time to re-locate the next line.

This PR:

  1. The "jump to" will locate the subtitle in the list and the video in the same time, which save me an extra click.
  2. New mining history log will not refresh the side panel if my current position is not the bottom.
  3. I add /scripts/web-socket-server/asbplayer-ws to the .gitignore because I made the server as a background service which is based on the binary file.

Now I can skip the step 2 shown in the following screenshot:

image

Update:

  1. 35395fa scripts/web-socket-server/build builds main.go into asbplayer-ws in the same directory

Copy link
Owner

@killergerbah killergerbah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This feels like an improvement to the jump-to behavior which was pretty bare bones. Also wondering if we can improve how we update the mining history in general, since it can get filled with a lot of similar cards.

@L-M-Sherlock
Copy link
Contributor Author

OK, now it works well in my test.

@L-M-Sherlock
Copy link
Contributor Author

I fixed a small bug to avoid jumping when loading new subtitle file.

Copy link
Owner

@killergerbah killergerbah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for doing this

@killergerbah killergerbah merged commit 491c3c7 into killergerbah:main Feb 16, 2026
1 check passed
@killergerbah killergerbah added this to the Extension v1.14.0 milestone Feb 16, 2026
@L-M-Sherlock L-M-Sherlock deleted the jump-to-seek branch February 17, 2026 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants