Skip to content

Comments

Fix potential issues with loc priming#884

Merged
killergerbah merged 1 commit intomainfrom
adjust-loc-priming
Feb 15, 2026
Merged

Fix potential issues with loc priming#884
killergerbah merged 1 commit intomainfrom
adjust-loc-priming

Conversation

@killergerbah
Copy link
Owner

@killergerbah killergerbah commented Feb 14, 2026

  • Prime localization on UPDATE - should fix missing loc when refreshing the extension on Firefox
  • Always prime a localization on install, even if we don't support the user's language.
  • Also fix the user language detection by removing the suffix. asbplayer doesn't currently support language codes with subtags.
  • On install, await the primeLocalization promise so that we finish priming before showing the FTUE page. primeLocalization can't throw an error so this is safe. Worst case we fail to prime and show the FTUE page anyway.

@killergerbah killergerbah requested a review from mwojick February 14, 2026 23:21
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 14, 2026

Deploying asbplayer with  Cloudflare Pages  Cloudflare Pages

Latest commit: e8e661f
Status: ✅  Deploy successful!
Preview URL: https://e83677b6.asbplayer.pages.dev
Branch Preview URL: https://adjust-loc-priming.asbplayer.pages.dev

View logs

@killergerbah killergerbah merged commit 9b7a1a5 into main Feb 15, 2026
2 checks passed
@killergerbah killergerbah added this to the Extension v1.14.0 milestone Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant