Skip to content

Comments

Fix some issues related to Netflix readings#882

Merged
killergerbah merged 3 commits intomainfrom
netflix-readings-fixes
Feb 14, 2026
Merged

Fix some issues related to Netflix readings#882
killergerbah merged 3 commits intomainfrom
netflix-readings-fixes

Conversation

@killergerbah
Copy link
Owner

@killergerbah killergerbah commented Feb 14, 2026

  • If multiple Netflix readings appear in same subtitle, their offsets should render correctly now. Tested with "無為‎転変" in the attached file.
  • If colorization is disabled, then returning token text as-is from applyTokenStyle. Without this, words with Netflix readings show up with the error style.

呪術廻戦 S02E45 変身 - ja - 日本語 [CC].nfvtt.txt

Copy link
Collaborator

@ShanaryS ShanaryS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I was originally worried about the regex replacement and using the offsets, as I wasn't sure if it should be right to left or be offset.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 14, 2026

Deploying asbplayer with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8a5b24a
Status: ✅  Deploy successful!
Preview URL: https://ed029a9d.asbplayer.pages.dev
Branch Preview URL: https://netflix-readings-fixes.asbplayer.pages.dev

View logs

@ShanaryS
Copy link
Collaborator

I realize the really issue is that applyTokenStyle() has been decoupled from SubtitleColoring so it can be called when dictionaryTrackEnabled() is false. Checking that should be the only thing that's needed as token.status shouldn't be undefined even if just using readings and frequencies.

@killergerbah killergerbah merged commit 1e8340b into main Feb 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants