Skip to content

Apply feedback on merge into cargo #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
epage merged 25 commits into from
Mar 15, 2022
Merged

Apply feedback on merge into cargo #670

epage merged 25 commits into from
Mar 15, 2022

Conversation

@epage
Copy link
Collaborator

@epage epage commented Mar 15, 2022

epage added 25 commits March 14, 2022 13:36
@epage
style: Use implicit format arguments
2fd1876
@epage
fix(error): Start errors with lowercase like cargo
70e801f
@epage
refactor: Remove dead long_help calls
06a3a60
@epage
fix(cli): Fix grammar error in '--help'
bbb035b
@epage
refactor: Reuse package name validation
ce59a44
@epage
refactor: Remove dead FromStr
ef60aec
@epage
refactor: Don't pollute scope with Context
8fdc49d
@epage
refactor: Remove unused assignment
674bf20
@epage
refactor: Remove redundant feature parse
69cc628
@epage
refactor: Move parse_feature to where to smallest scope
70c9bc0
@epage
docs: Clarify pre-release shenanigans
769166c
@epage
docs: Clarify why features are read from oldest version
bf8d11c
@epage
chore: Remove references to clippy
e67e9b7
@epage
refactor: Simplify dep table lookup
2ead775
@epage
refactor: Allow more error reports
2a383f9
@epage
fix: Don't ignore manifest errors
67eee4f
@epage
fix: Error on default_features
0d30afa
@epage
fix: Error on deprecated dependency sections
111f903
@epage
refactor: Make DepTable owned
18265f2
@epage
refactor: Move DepTable to be with Manifest
46f6702
@epage
refactor: Decouple Kind and Target for DepTable
5aa3de9
@epage
fix: Allow target-specific dev/build deps
f248c85
@epage
refactor: Consolidate kind table names
0f5869b
@epage
refactor: Always operate on DepTable
1e738a0
@epage
test: Ensure we can add dep when only pre-releases exist
84af19b
@epage epage merged commit 295e9c7 into killercup:merge-add Mar 15, 2022
@epage epage deleted the feedback branch March 15, 2022 02:31
@epage epage mentioned this pull request Mar 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@epage