Skip to content

perf: respect depth limit in countCycles #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kikito merged 1 commit into from
Jan 5, 2026
Merged

perf: respect depth limit in countCycles #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions inspect.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,17 +154,19 @@ local function getKeys(t)
return keys, keysLen, seqLen
end

local function countCycles(x, cycles)
local function countCycles(x, cycles, depth)
if type(x) == "table" then
if cycles[x] then
cycles[x] = cycles[x] + 1
else
cycles[x] = 1
for k, v in rawpairs(x) do
countCycles(k, cycles)
countCycles(v, cycles)
if depth > 0 then
for k, v in rawpairs(x) do
countCycles(k, cycles, depth - 1)
countCycles(v, cycles, depth - 1)
end
countCycles(getmetatable(x), cycles, depth - 1)
end
countCycles(getmetatable(x), cycles)
end
end
end
Expand Down Expand Up @@ -327,7 +329,7 @@ function inspect.inspect(root, options)
end

local cycles = {}
countCycles(root, cycles)
countCycles(root, cycles, depth)

local inspector = setmetatable({
buf = { n = 0 },
Expand Down
14 changes: 8 additions & 6 deletions inspect.tl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,17 +154,19 @@ local function getKeys(t: table): {any}, integer, integer
return keys, keysLen, seqLen
end

local function countCycles(x: any, cycles: {any:integer}): nil
local function countCycles(x: any, cycles: {any:integer}, depth: integer): nil
if x is table then
if cycles[x] then
cycles[x] = cycles[x] + 1
else
cycles[x] = 1
for k,v in rawpairs(x) do
countCycles(k, cycles)
countCycles(v, cycles)
if depth > 0 then
for k,v in rawpairs(x) do
countCycles(k, cycles, depth - 1)
countCycles(v, cycles, depth - 1)
end
countCycles(getmetatable(x), cycles, depth - 1)
end
countCycles(getmetatable(x), cycles)
end
end
end
Expand Down Expand Up @@ -327,7 +329,7 @@ function inspect.inspect(root: any, options: inspect.Options): string
end

local cycles = {}
countCycles(root, cycles)
countCycles(root, cycles, depth)

local inspector = setmetatable({
buf = { n = 0 },
Expand Down
Loading