-
Notifications
You must be signed in to change notification settings - Fork 37
Update theme-variants.md #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v11
Are you sure you want to change the base?
Conversation
WalkthroughThe documentation for theme variants was expanded by adding two new sections. The first section, "Viewing your variants," outlines the process for assigning and testing theme variants, including steps for configuring realms, clients, and storybook usage. The second section, "In Emails," describes how to reference the theme variant name within email templates using a specific variable syntax. No changes were made to code or exported entities. Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
features/theme-variants.md (2)
54-59: Enhance clarity for "Viewing your variants" steps
The numbered list is clear, but step 3's inline snippet is truncated and the JSX tag isn't closed. Consider expanding it into a fenced code block and ensuring proper markdown escaping of the braces. For example:- 3. Apply the theme name in the `kcContext` of the storybook story: `<KcPageStory kcContext={{ themeName: "chocolate" }}...` + 3. Apply the theme name in the `kcContext` of the Storybook story: + ```tsx + <KcPageStory kcContext={{ themeName: "chocolate" }} /> + ```This makes the example self-contained and avoids confusion around the ellipsis.
107-109: Clarify "In Emails" usage with a concrete example
You mention accessing${xKeycloakify.themeName}, but users may benefit from seeing it in context. For instance, in a Freemarker email template:<p>Your selected theme variant is ${xKeycloakify.themeName}.</p>You could also note which templating engines (e.g., FTL, Mustache) support this variable.
Summary by CodeRabbit