Skip to content

klish: Do not autocomplete nodes that do not pass a when expression #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mattiaswal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

klish: Do not autocomplete nodes that do not pass a when expression #1336

mattiaswal wants to merge 1 commit into from
+2 −2

Conversation

@mattiaswal
Copy link
Contributor

@mattiaswal mattiaswal commented Dec 24, 2025 •
edited
Loading

This is most noticeable in interface context

admin@infix-00-00-00:/config/interface/e1/> set type wifi admin@infix-00-00-00:/config/interface/e1/> set
bind-ni-name bridge-port container-network custom-phys-address description enabled ethernet

where you previously got all containers for all interface-types (here just ethernet)

Description

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe):

@mattiaswal
klish: Do not autocomplete nodes that do not pass a when expression
8a638fa 
This is most noticeable in interface context

admin@infix-00-00-00:/config/interface/e1/> set type wifi
admin@infix-00-00-00:/config/interface/e1/> set
bind-ni-name         bridge-port   container-network custom-phys-address         description             enabled            ethernet

where you previously got *all* containers for all interface-types.
@mattiaswal mattiaswal requested review from troglobit and wkz December 24, 2025 21:11
@mattiaswal mattiaswal marked this pull request as ready for review December 24, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@troglobit troglobit Awaiting requested review from troglobit

@wkz wkz Awaiting requested review from wkz

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mattiaswal