Fix unnecessary audio transcoding #154
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I tried to prepare a video so that no transcoding was necessary, I noticed this was impossible, even if I used exactly the same `ffmpeg` call gnomecast was using. I chased this down to an `or` that probably should have been an `and`: we want to transcode if we have an unsupported audio format *and* we can't play the embedded audio stream.
|
I also had to fix the line above when trying to play bare mp3 files: self.transcode_video = force_video or (self.video_stream and not self.can_play_video_codec(video_stream.codec))
self.transcode_audio = force_audio or (self.audio_stream and all(stream.codec not in AUDIO_EXTS for stream in fmd.audio_streams)) or not self.can_play_audio_stream(self.audio_stream)
self.transcode = transcode_container or ((self.transcode_video or self.transcode_audio) and transcode_container)Still didn't manage to get it working tho |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I tried to prepare a video so that no transcoding was necessary, I noticed
this was impossible, even if I used exactly the same
ffmpegcall gnomecast wasusing. I chased this down to an
orthat probably should have been anand:we want to transcode if we have an unsupported audio format and we can't play
the embedded audio stream.
Thanks a lot for this project!