Skip to content

Conversation

@Serial-ATA
Copy link
Contributor

@Serial-ATA Serial-ATA commented Nov 21, 2025

closes #126

Draft for now, since it could probably use more tests

@kellnerd kellnerd added feature New feature or request provider Metadata provider labels Nov 23, 2025
Copy link
Owner

@kellnerd kellnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Despite the number of comments, this is looking good already.
I will soon test the provider a bit myself to see where we potentially need more test cases.

P.S. Regarding the CI complaints about formatting, we can fix that by ignoring the testdata folder in the fmt.exclude setting in deno.json.

Copy link
Owner

@kellnerd kellnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provider is looking good to me and test coverage is probably sufficient for now.
Is there any other reason why this PR is still marked as draft?
The fact that mora doesn't split off featured artists (and even assigns an artist ID to such collaborations) is probably better handled as part of a general solution (#119).

In future versions we might want to expose artist names and titles in Kana (another use case of #70) and maybe even put bit depth and sampling frequency into an annotation.

I've also noticed that tracks have individual image URLs, but I haven't seen a release with track-specific images. Even if Harmony had an image de-duplication feature, it probably wouldn't be worth it to extract 200px track images.

@Serial-ATA
Copy link
Contributor Author

Is there any other reason why this PR is still marked as draft?

Nope, just for the tests

I've also noticed that tracks have individual image URLs, but I haven't seen a release with track-specific images. Even if Harmony had an image de-duplication feature, it probably wouldn't be worth it to extract 200px track images.

Yeah, I checked around too and never found one. mora is a pretty terrible source for images, anyway.

@Serial-ATA Serial-ATA marked this pull request as ready for review November 30, 2025 17:53
@kellnerd kellnerd merged commit 49e07d8 into kellnerd:main Dec 1, 2025
2 checks passed
@Serial-ATA Serial-ATA deleted the mora branch December 1, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request provider Metadata provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for mora.jp

2 participants