You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I believe that most of the time the main env file will be stored into the same folder as the schema and defaults. It will help to reduce repetitive code.
Hi @agodinhost . Thank you for the PR. I do like the direction of this PR. However, this does present a potential issue with the documentation. The docs state that the default values for defaults option is .env.defaults and schema is .env.schema. With your change, it does not make clear that the prefix for the defaults and schema will be whatever is in the path option.
For example, someone could have .env-prod as the path option but could have .env.schema as the schema file. Without an update to the docs, they might assume that since the docs say the default is .env.schema then it would pick that up.
You could either update the docs to indicate that defaults and schema are path + '.defaults' and path + '.schema' or ES6 style `${path}.defaults` and `${path}.schema\`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Keith.
I did a minor enhancement in the schema and defaults paths - now it will follow the path of the main env file.
For example:
is the same as:
I believe that most of the time the main env file will be stored into the same folder as the schema and defaults. It will help to reduce repetitive code.
thanks