Across and down blocks of length one no longer treated as across or down clues.#43
Open
impregnablequestion wants to merge 2 commits intokeiranking:masterfrom
Open
Across and down blocks of length one no longer treated as across or down clues.#43impregnablequestion wants to merge 2 commits intokeiranking:masterfrom
impregnablequestion wants to merge 2 commits intokeiranking:masterfrom
Conversation
Modified this function so that I could use Phil Crossword to write cryptic style crosswords without down clues being generated for each square in a single across clue
Made an oversight in terms of checking that clues on the final row or column were properly handled, updated now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified the cross.js file slightly so that I could use Phil Crossword to write cryptic style crosswords without down clues and labels being generated for each square in a single across clue, and vice versa.
Achieved this by updating the IsAcross and IsDown conditions in the UpdateLabelsAndClues function in cross.js (line 535) to loop to the second last index in each row and column (the last index will never be a valid clue) and adding a check for the following square in the row not being filled black. Have tested it extensively and no other functionality in the app is broken by this change.
Before:
For the purposes of creating an english-style cryptic grid I couldn't use Phil Crossword, as it generated invalid labels and clues
After:
Phil Crossword now works for my purposes, and doesn't generate labels or clues that have a length of one