Fixed numbering issues#19
Open
joetime wants to merge 1 commit intokeiranking:masterfrom
joetime:master
Open
Conversation
|
Thanks for fixing this issue! I was able to apply your patch and create a sweet puzzle 😁 I noticed an issue where two letter words were not being assigned a number. In |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went ahead and fixed this issue. See before and after below. In BEFORE the across numbers 11, 12, 13, 14, 17, etc. are incorrect.
I also added an option for 'allow two letter words' that can be utilized in the future.
Note this also fixes/removes the total number of clues listed in the printout (i.e. it removes the unused ones).
Thanks for this amazing application! I have a few more ideas I'd like to implement, so hopefully you appreciate the help.
BEFORE:
AFTER:
