Feature/004 terraform #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justwes2
commented
Jun 27, 2019
Contributor
Author
justwes2
left a comment
justwes2
left a comment
There was a problem hiding this comment.
Instead of setting this role as a default variable, can you leave it unset, and pass it in in the module in prod/main.tf?
Thanks
justwes2
commented
Jun 28, 2019
Contributor
Author
justwes2
left a comment
justwes2
left a comment
There was a problem hiding this comment.
What was the thinking behind hardcoding the cidrs? Usually the best practice is to parameterize as much as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated jenkinsfile and jenkinsfile.integration, see builds. Tweaks to terraform for public ip.