Skip to content

Conversation

@3llomi
Copy link
Contributor

@3llomi 3llomi commented Dec 23, 2025

Currently AVURLAsset doesn't recognize the video file if it doesn't have an extension e.g. '.mp4'
So I added a mime type detection so it can load videos without the need to the extension.

@kdroidFilter kdroidFilter merged commit e470aee into kdroidFilter:master Dec 24, 2025
2 of 3 checks passed
@3llomi
Copy link
Contributor Author

3llomi commented Dec 27, 2025

I noticed that I didn't push the native dylibs after updating the code.

Currently when trying to build using
./gradlew buildNativeLibraries

It throws an error

> Task :mediaplayer:buildNativeMacX64 FAILED
mediaplayer/src/jvmMain/kotlin/io/github/kdroidfilter/composemediaplayer/mac/native/NativeVideoPlayer.swift:1075:97: error: cannot convert value of type 'Unmanaged<MTAudioProcessingTap>?' to expected argument type 'MTAudioProcessingTap?'
1073 |             // Create the audio processing tap
1074 |             let status = MTAudioProcessingTapCreate(
1075 |                 kCFAllocatorDefault, &callbacks, kMTAudioProcessingTapCreationFlag_PostEffects, &tap
     |                     |- error: cannot convert value of type 'Unmanaged<MTAudioProcessingTap>?' to expected argument type 'MTAudioProcessingTap?'
     |        - note: arguments to generic parameter 'Wrapped' ('Unmanaged<MTAudioProcessingTap>' and 'MTAudioProcessingTap') are expected to be equal
1076 |             )
1077 |             if status == noErr, let tap = tap {

Related to these lines in NativeVideoPlayer.swift

  var tap: Unmanaged<MTAudioProcessingTap>?
            // Create the audio processing tap
            let status = MTAudioProcessingTapCreate(
                kCFAllocatorDefault, &callbacks, kMTAudioProcessingTapCreationFlag_PostEffects, &tap
            )

Can you check if it builds for you @kdroidFilter ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants