Skip to content

Conversation

@ialarmedalien
Copy link
Collaborator

Description of PR purpose/changes

  • Please include a summary of the change and which issue is fixed.
  • Please also include relevant motivation and context.
  • List any dependencies that are required for this change.

Testing Instructions

  • Details for how to test the PR:
  • Tests pass locally and in GitHub Actions

Dev Checklist:

  • My code follows the guidelines at https://sites.google.com/lbl.gov/trussresources/home?authuser=0
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have run Ruff format to format my code
  • I have run Ruff check and fixed any errors that it uncovered
  • Any dependent changes have been merged and published in downstream modules

Updating Version and Release Notes (if applicable)

@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

❌ Patch coverage is 77.54011% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.67%. Comparing base (2db2ff5) to head (b9900c2).
⚠️ Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
src/cdm_data_loader_utils/utils/minio.py 30.23% 30 Missing ⚠️
...cdm_data_loader_utils/parsers/uniprot/idmapping.py 85.36% 6 Missing ⚠️
.../cdm_data_loader_utils/parsers/uniprot/metalink.py 90.74% 5 Missing ⚠️
.../cdm_data_loader_utils/parsers/uniprot/relnotes.py 97.87% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #72      +/-   ##
===========================================
+ Coverage    51.18%   52.67%   +1.49%     
===========================================
  Files           59       63       +4     
  Lines         3048     3233     +185     
===========================================
+ Hits          1560     1703     +143     
- Misses        1488     1530      +42     
Files with missing lines Coverage Δ
src/cdm_data_loader_utils/parsers/uniprotkb.py 57.18% <ø> (ø)
...m_data_loader_utils/utils/download/async_client.py 100.00% <100.00%> (ø)
...dm_data_loader_utils/utils/download/sync_client.py 100.00% <100.00%> (ø)
.../cdm_data_loader_utils/parsers/uniprot/relnotes.py 97.87% <97.87%> (ø)
.../cdm_data_loader_utils/parsers/uniprot/metalink.py 90.74% <90.74%> (ø)
...cdm_data_loader_utils/parsers/uniprot/idmapping.py 85.36% <85.36%> (ø)
src/cdm_data_loader_utils/utils/minio.py 30.23% <30.23%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24cc1aa...b9900c2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ialarmedalien ialarmedalien force-pushed the idmapping branch 3 times, most recently from 5cf2cf5 to ed20c46 Compare January 27, 2026 17:28
@ialarmedalien ialarmedalien merged commit 4cf9ebb into develop Jan 28, 2026
9 of 10 checks passed
@ialarmedalien ialarmedalien deleted the idmapping branch January 28, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants