Conversation
sfnelson
approved these changes
Jan 27, 2026
Contributor
sfnelson
left a comment
There was a problem hiding this comment.
This change makes sense but it's a response to a wider deprecation of ActiveSupport::Configurable in Rails 8.1. I took a 'light' approach in this plus the other gems like content and koi, rather than the much more complex approach Rails took internally. Is this approach consistent with how Rails has tackled the deprecation?
sfnelson
reviewed
Jan 27, 2026
78f4f4a to
6a27476
Compare
sfnelson
approved these changes
Jan 27, 2026
6a27476 to
3524866
Compare
sfnelson
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of our projects (glg, gus, nfsa-pro) use Collections::Base with inheritance. They define an 'ApplicationCollection' with common settings and then inherit from that. Example code:
The expectation being that config in ApplicationCollection is inherited by SomeController::Collection. That doesn't seem to happen, as we use a class variable
@configwhich is not inherited. This PR changes@configto aclass_attribute, anddups it for subclasses. And added some tests.