Enable media deep linking and optimized mobile thumbnails #161
+185
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `thumbnail_type`, `thumbnail_source`, and `thumbnail_id` fields to `DiveSiteResponse` schema - Update `get_dive_sites` endpoint to populate thumbnail metadata - Implement `getMediaLink` in `DiveSites.js` to generate deep links with media params - Add deep link handling in `DiveSiteDetail.js` to open lightbox for photos or scroll to videos - Update `YouTubePreview` to support internal modal playback, autoplay, and auto-open behavior - Add `autoplay` support to `getYouTubeEmbedUrl` helper - Switch video thumbnails to open internal modal instead of new tab - Refactor dive site list layout for mobile: move thumbnail to the right of description - Ensure dive site name and location span full width on mobile devices
kargig
force-pushed
the
enhance_thumbnail_actions
branch
from
74c7664 to
c8b18a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thumbnail_type,thumbnail_source, andthumbnail_idfields toDiveSiteResponseschemaget_dive_sitesendpoint to populate thumbnail metadatagetMediaLinkinDiveSites.jsto generate deep links with media paramsDiveSiteDetail.jsto open lightbox for photos or scroll to videosYouTubePreviewto support internal modal playback, autoplay, and auto-open behaviorautoplaysupport togetYouTubeEmbedUrlhelper