Improve dive site media discoverability and UI #158
Merged
+289
−188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Backend:
- Add 'thumbnail' field to DiveSiteResponse schema.
- Implement randomized thumbnail selection from all
site/dive media (photos and videos).
- Add YouTube thumbnail extraction and R2 presigned
URL resolution for thumbnails.
- Frontend:
- Synchronize DiveSiteDetail tabs with '?tab=' URL
parameter for deep linking.
- Display thumbnails in dive site list and grid
views with direct links to the media tab.
- Fix grid view empty states for rating and depth.
- Show full clickable URLs in site descriptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend:
Frontend: