Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do and why is it necessary?
Sets the GPIOD label (consumer field) when requesting GPIO pins (with the periphery library); by default the pin consumer is set to
peripherywhile the pin is used. This change simply sets the consumer message tooctoprint-[NAME]where 'NAME' is the printer name from the main OctoPrint settings.How was it tested? How can it be tested by the reviewer?
Tested locally on my system, this trivial enough (arguments added on just two lines) that it can be reviewed and tested on any GPIOD enabled instance. Use
gpioinfo | grep "\[used\]"to see the current list of used pins, status and consumer stringsNotes
This is trivial, and this plugin is currently stalled, but if anybody works on it again this would be a 'nice to have' change.
This is the result on my install
becomes: