Skip to content

Respect overridden sessionserver & api urls #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mathiascode merged 1 commit into from
Oct 25, 2025
Merged

Respect overridden sessionserver & api urls #388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 29 additions & 7 deletions src/main/java/pw/kaboom/extras/modules/player/skin/SkinManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,24 @@ public final class SkinManager {
private static final Gson GSON = new Gson();
private static final ExecutorService executorService = Executors
.newCachedThreadPool();
private static final URI SESSION_HOST =
URI.create(
System.getProperty(
"minecraft.api.session.host",
"https://sessionserver.mojang.com"
)
);
private static final URI PROFILE_ENDPOINT = URI.create(
// 1.21.9+
System.getProperty(
"minecraft.api.profiles.host",
System.getProperty(
// 1.21.9-
"minecraft.api.session.host",
"https://api.mojang.com"
)
)
);

public static void resetSkin(final Player player, final boolean shouldSendMessage) {
executorService.submit(() -> {
Expand Down Expand Up @@ -128,8 +146,10 @@ public static CompletableFuture<SkinData> getSkinData(final String playerName) {
public static CompletableFuture<SkinData> getSkinData(final UUID uuid) {
return CompletableFuture.supplyAsync(() -> {
final SkinResponse response = sendRequestForJSON(
"https://sessionserver.mojang.com/session/minecraft/profile/"
+ uuid + "?unsigned=false", SkinResponse.class);
SESSION_HOST,
"/session/minecraft/profile/" + uuid + "?unsigned=false",
SkinResponse.class
);

final List<ProfileProperty> properties = response.properties();

Expand All @@ -145,10 +165,10 @@ public static CompletableFuture<SkinData> getSkinData(final UUID uuid) {
}, executorService);
}

private static <T> T sendRequestForJSON(String url, Class<T> clazz) {
private static <T> T sendRequestForJSON(URI uri, String endpoint, Class<T> clazz) {
final HttpRequest request = HttpRequest.newBuilder()
.GET()
.uri(URI.create(url))
.uri(uri.resolve(endpoint))
.build();

final HttpResponse<String> response;
Expand All @@ -164,9 +184,11 @@ private static <T> T sendRequestForJSON(String url, Class<T> clazz) {

private static CompletableFuture<UUID> getUUID(final String playerName) {
return CompletableFuture.supplyAsync(() -> {
final ProfileResponse parsedResponse = sendRequestForJSON
("https://api.mojang.com/users/profiles/minecraft/" + playerName,
ProfileResponse.class);
final ProfileResponse parsedResponse = sendRequestForJSON(
PROFILE_ENDPOINT,
"/users/profiles/minecraft/" + playerName,
ProfileResponse.class
);

final String dashedUuid = parsedResponse
.id()
Expand Down